fix images encoding in dist zip #3615
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ee865d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
becky-gilbert
requested changes
Oct 30, 2025
There was a problem hiding this comment.
Thanks very much @Jolg42, this looks great and works perfectly.
I just have one tiny comment on the changeset, otherwise I think it's ready to go.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "jspsych": patch | |||
There was a problem hiding this comment.
I think this should actually be an update to the config package, rather than jspsych.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3577
Hi,
It's my first PR here 👋🏼
I verified the state before and after the PR, the images were corrupted before and working as expected after.
The change is needed for binary files since Gulp v5, see
gulpjs/gulp#2777 (comment)